-
Notifications
You must be signed in to change notification settings - Fork 83
Add images to the Disaster recovery page #2619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add images to the Disaster recovery page #2619
Conversation
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Show resolved
Hide resolved
0a2fd7a
to
6598d6c
Compare
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the pictures are nice and that it will be easier to follow the guide with a more visual example. However, I feel like putting the pictures in the middle of the guide might be confusing, since the picture might not reflect the state for a user at all depending on how the disaster looks.
For example, if system database is not lost the pictures might be quite confusing when the user is on the section about fixing server availability. What do you think about having an additional section after the guide which goes through the example instead? Then we could also keep the guide itself more concise since we wouldn't need to remove the pop ups.
Also, do you think we should be more clear about the fact that the pictures only show how the databases are allocated. Because even though the allocations might be fine after the server step in our example, the last step is still needed to see that the databases are actually started and available.
What do you think? Pros vs cons?
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Show resolved
Hide resolved
modules/ROOT/pages/clustering/multi-region-deployment/disaster-recovery.adoc
Show resolved
Hide resolved
I understand your concerns. Let me apply your suggestions to the page first so we can review the final result. Personally, I believe the images work well here -- they complement our disaster example effectively. |
8bd24c0
to
cbaef33
Compare
This PR includes documentation updates Updated pages: |
That sounds like a good idea! Lets see what someone else thinks 😄 |
No description provided.